Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu location in alert #9783

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

8manz
Copy link
Contributor

@8manz 8manz commented Aug 23, 2023

Fixes: #9767

When unable to fetch a favicon and the DuckDuckGo website icon service is not enabled, returns a message with the wrong location to enable. Source changed to "You can enable the DuckDuckGo website icon service under Application Settings -> Security".

Screenshots

screenshot

Testing strategy

Checked in Qt Linguist for the change in source text

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

You should ONLY change the wording in the cpp file then run ./release-tool i18n lupdate

@8manz
Copy link
Contributor Author

8manz commented Aug 23, 2023

Sorry, is this what you meant?

@droidmonkey
Copy link
Member

Yes precisely

@droidmonkey droidmonkey merged commit 07232f0 into keepassxreboot:develop Jan 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong menu location in user alert
3 participants